Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to parry2d #251

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from
Open

Switch to parry2d #251

wants to merge 9 commits into from

Conversation

drobnyjt
Copy link
Collaborator

Thank you for your contribution to RustBCA!

Before submitting this PR, please make sure you have:

  • Opened an issue
  • Referenced the relevant issue number(s) below
  • Provided a description of the changes below
  • Ensured all tests pass and added any necessary tests for new code

Fixes #245 #222 #181

Description

This PR replaces dependence on geo with parry2d. This is being done for several reasons:

  • geo is primarily a geospatial primitives library, not a 2d collision detection library
  • RustBCA already uses parry3d for the 3d features
  • geo's collision detection for polygons has a significant weak point - it does not determine the nearest point on the boundary of a polygon if the point is inside the polygon (i.e., it assumes all polygons are solid). This is the cause of issue [bug] rare issue with planar surface binding potential in Mesh2D case #245
  • parry2d has a built-in 2d trimesh that should be much faster than the RustBCA version

Tests

All tests run successfully using cargo test.

Notes

This initial push request retains all of geo's features and imports. Once testing is finalized, these will be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant